mailRe: r23508 - /trunk/user_functions/dx.py


Others Months | Index by Date | Thread Index
>>   [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Header


Content

Posted by Edward d'Auvergne on May 28, 2014 - 14:57:
Hi,

Unfortunately it is a large effort to keep the GUI functional.  I have
essentially rewritten the GUI twice since the relax GUI paper:

-  Bieri, M., d'Auvergne, E., and Gooley, P. (2011). relaxGUI: a new
software for fast and simple NMR relaxation data analysis and
calculation of ps-ns and s motion of proteins. J. Biomol. NMR, 50,
147-155. (http://dx.doi.org/10.1007/s10858-011-9509-1).

I need to create more GUI tests, including adding special methods to
allow certain parts of the GUI, to improve the stability.  For
curiosity, if you'd like to see the difference to the original version
(https://gna.org/forum/forum.php?forum_id=2256), just type:

$ svn co http://svn.gna.org/svn/relax/tags/1.3.9
$ cd 1.3.9
$ ./relax -g

This was actually my first completely rewrite.  The real original 2009
version, in a pseudo-functional state is:

$ svn co http://svn.gna.org/svn/relax/branches/bieri_gui@r9989
$ cd bieri_gui
$ ./relax --bieri

Anyway, if you could revert your change of r23508, I will then make a
GUI test to make sure that the dim = (None, 3) setting will produce
the expected result.

Cheers,

Edward



On 28 May 2014 12:53, Troels Emtekær Linnet <tlinnet@xxxxxxxxxxxxx> wrote:
Cheers!

I very much appreciate it.

I can't wonder how you have kept up the good mood, to fight these GUI
problems...

To build that up, must have taken its toll.

Best
Troels

2014-05-28 12:32 GMT+02:00 Edward d'Auvergne <edward@xxxxxxxxxxxxx>:
Hi,

Like I said, I'll fix it.  There are some regressions in the
Sequence_2D GUI element as this was never checked in the test suite.
I'll create the necessary GUI tests and fix it in the trunk.  This is
what naturally happens to code when it is not part of the test suite.

Regards,

Edward



On 28 May 2014 12:26, Troels Emtekær Linnet <tlinnet@xxxxxxxxxxxxx> wrote:
Well...

That is not how the GUI is responding.

If I make (None, 3), there is only 2 input fields.

The logic of getting this GIU thing to work, is quite a hard work.
This has costed now 2-3 hours, to get this little simple thing to work.

It must have been a pain to build it up!

Best
Troels


2014-05-28 12:11 GMT+02:00 Edward d'Auvergne <edward@xxxxxxxxxxxxx>:
Hi Troels,

Setting the dimensions to (None, 4) means that you have a user defined
number of points, but each point is 4D [x, y, z, t].

Regards,

Edward



On 28 May 2014 12:09,  <tlinnet@xxxxxxxxxxxxx> wrote:
Author: tlinnet
Date: Wed May 28 12:09:37 2014
New Revision: 23508

URL: http://svn.gna.org/viewcvs/relax?rev=23508&view=rev
Log:
Modified the dim dimensions to (None, 4) to allow the user to change 
number of points in the GUI.

THe first dimension was used as a counter, the last 3 dimensions is for 
x,y,z position.

This is for the user function dx.map.

Modified:
    trunk/user_functions/dx.py

Modified: trunk/user_functions/dx.py
URL: 
http://svn.gna.org/viewcvs/relax/trunk/user_functions/dx.py?rev=23508&r1=23507&r2=23508&view=diff
==============================================================================
--- trunk/user_functions/dx.py  (original)
+++ trunk/user_functions/dx.py  Wed May 28 12:09:37 2014
@@ -177,7 +177,7 @@
     desc_short = "highlight points in the space",
     desc = "This argument allows specific points in the optimisation 
space to be displayed as coloured spheres.  This can be used to 
highlight a minimum or other any other feature of the space.  Either a 
single point or a list of points can be supplied.  Each point is a list 
of floating point numbers in the form [x, y, z]",
     can_be_none = True,
-    dim = (None, 3)
+    dim = (None, 4)
 )
 uf.add_keyarg(
     name = "point_file",


_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-commits mailing list
relax-commits@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-commits

_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
relax-devel@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel



Related Messages


Powered by MHonArc, Updated Wed May 28 15:20:16 2014