Hi Troels,
This looks like a good implementation. You just need some whitespace
around '=' and a newline before each comment for better readability.
And maybe, because it is not a module but software, you could call
'showApod_module' as 'showApod' or 'showApod_software'.
Cheers,
Edward
On 3 September 2014 22:50, <tlinnet@xxxxxxxxxxxxx> wrote:
Author: tlinnet
Date: Wed Sep 3 22:50:23 2014
New Revision: 25602
URL: http://svn.gna.org/viewcvs/relax?rev=25602&view=rev
Log:
Added dependency check for the NMRPipe showApod program.
This program can be really usefull, if processing a large amount of data,
and quickly needs to asses the RMSD of the spectrum.
Modified:
trunk/dep_check.py
Modified: trunk/dep_check.py
URL:
http://svn.gna.org/viewcvs/relax/trunk/dep_check.py?rev=25602&r1=25601&r2=25602&view=diff
==============================================================================
--- trunk/dep_check.py (original)
+++ trunk/dep_check.py Wed Sep 3 22:50:23 2014
@@ -252,6 +252,27 @@
subprocess_module = False
subprocess_module_message = message.args[0]
+# NMRPipe showApod
+if subprocess_module:
+ try:
+ # Call function.
+ Temp=subprocess.Popen('showApod', stdout=subprocess.PIPE)
+ # Communicate with program, and get output and error output.
+ (output, errput) = Temp.communicate()
+ # Wait for finish and get return code.
+ return_value = Temp.wait()
+
+ # Split the output into lines.
+ line_split = output.splitlines()
+ if line_split[0] == 'showApod: Show Effect of Processing on Noise
and Linewidth.':
+ showApod_module = True
+ else:
+ showApod_module = False
+ except OSError:
+ showApod_module = False
+else:
+ showApod_module = False
+
# ctypes module.
try:
import ctypes
_______________________________________________
relax (http://www.nmr-relax.com)
This is the relax-commits mailing list
relax-commits@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-commits
Re: r25602 - /trunk/dep_check.py