mailRe: r27844 - /trunk/multi/processor.py


Others Months | Index by Date | Thread Index
>>   [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Header


Content

Posted by Edward d'Auvergne on June 08, 2015 - 17:35:
Hi Troels,

I would suggest reverting this change is it is detrimental for the
model-free analyses where this chunking can really help.  Maybe there
is a way to do this on a per analysis level, but I'm not convinced
that this change would help anyway.

Cheers,

Edward


On 27 May 2015 at 03:09,  <tlinnet@xxxxxxxxxxxxx> wrote:
Author: tlinnet
Date: Wed May 27 03:09:57 2015
New Revision: 27844

URL: http://svn.gna.org/viewcvs/relax?rev=27844&view=rev
Log:
Suggestion Fix 1, in multi.processor.run_queue().

This fix changes, that the amount of simulations is not chunked up before 
sending each chunk to a CPU.
Rather, all jobs are to be submitted after each other, and finished for 
themselves.

Bug #23618: (https://gna.org/bugs/index.php?23618): queuing system for 
multi processors is not well designed.

Modified:
    trunk/multi/processor.py

Modified: trunk/multi/processor.py
URL: 
http://svn.gna.org/viewcvs/relax/trunk/multi/processor.py?rev=27844&r1=27843&r2=27844&view=diff
==============================================================================
--- trunk/multi/processor.py    (original)
+++ trunk/multi/processor.py    Wed May 27 03:09:57 2015
@@ -633,8 +633,8 @@
         """

         #FIXME: need a finally here to cleanup exceptions states
-        lqueue = self.chunk_queue(self.command_queue)
-        self.run_command_queue(lqueue)
+        #lqueue = self.chunk_queue(self.command_queue)
+        self.run_command_queue(self.command_queue)

         del self.command_queue[:]
         self.memo_map.clear()


_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-commits mailing list
relax-commits@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-commits



Related Messages


Powered by MHonArc, Updated Mon Jun 08 18:20:09 2015