>> 1. this does much more than the required task and covers most states of
>> python floats. This is because having sorted through how a ieee number
>> works it seemed easier to do all the 'float things' while I had my head
>> round it
>
>
> The number of floating point functions is unbelievable, these should
> come in very handy in the future. Thank you. Maybe after a bit of
> polish you should consider submitting it for inclusion into Python.
> 'fpconst' is one day going into Python, but this code is a much more
> advanced and complete implementation!
>
>
glad you liked it there are a few more 'goodies to follow'
Intriguing! Feel free to commit partially functional code. As long
as relax doesn't break, I would recommend committing many small
changes rather than one large change.
> There are a few minor things which need to be sorted out. The first
> thing is that relax no longer starts up. This is easy to fix though,
> just delete the import line, etc. from the file 'relax'. The other
> problem is this message:
>
done this, and know how to run the relax test suite now ;-)
> DeprecationWarning: Non-ASCII character '\xe2' in file
> /mnt/removable/relax/float.py on line 35, but no encoding declared;
> see http://www.python.org/peps/pep-0263.html for details
>
done
> The easy fix is to use standard ASCII characters to represent the
> text. There are four instances where a Unicode (I'm assuming)
> character appear in your new code. The next thing is import 'isInf'
> and 'isNaN' into 'specific_fns/model_free.py' and uncomment the two
> lines.
>
done
> Gary would you like to make these three easy changes? I probably
> won't have repository access until tomorrow. Thanks.
>
...
Thanks.
Its no problem to do the cosmetic stuff and I will put the code into
the epydoc format when i get a chance (thats fairly easy it looks like
javadoc)
(I will try and find a code prettifier to do the spacing stuff, there is
a quite alot to do and pydev seems to be being remarkably uncooperative
on spacing sizes)
The spacings pretty simple. If you're using gvim just search for a
space and you'll see a sea of yellow. The search command '/ $' will
find all the terminal whitespace. And consistent spacing between
functions, etc is pretty simple as well. In relax most often there
are two empty lines between functions. Then a single empty line after
the docstring. For spacing in front of the I have generally used the
same indenting for the string as the code straight after the
docstring. There are a number of other little things which can be
seen in the relax codebase. All these things are trivial but make the
code more consistent with the rest of relax. Although the change has
no function, the consistency and richness of comments (comments are
probably about a third of the text in relax) makes the code so much
more readable. I don't have a problem reading your code, but those
new to relax and coding in general may struggle with certain bits.
Thanks.
on another note
on the page http://www.nmr-relax.com/communication.html
there is the text
relax-commits
One last mailing list is the relax commits list. This list is reserved
for automatically generated posts created by the version control
software which looks after the relax source code and these web pages. If
you would like to become a developer, you can subscribe to the list at
relax-commits information page
<https://mail.gna.org/listinfo/relax-commits/>. The list can also be
browsed <https://mail.gna.org/public/relax-users/>.
browsed has the url https://mail.gna.org/public/relax-users/ ;-) so it
leeds to the user archive page not the commits page
Whoops. Would you like to have a go at fixing it? Otherwise I'll fix
it later when I have access to the repositories. The web pages are
stored in a CVS repository (see https://gna.org/cvs/?group=relax). If
you haven't used CVS before, it's essentially the same commands as
SVN.
Edward
Re: float.py