Hi, It's no problem at all. That's how open source is supposed to work. It should make better code with less bugs and with more features :) Regards, Edward On Jan 8, 2008 8:02 PM, Sebastien Morin <sebastien.morin.1@xxxxxxxxx> wrote:
Hi Ed, Perfect. I corrected this issue and placed back these values in the Ct default_value() method. Thanks for checking what I do and giving me good advices !!! Cheers, Sébastien Edward d'Auvergne wrote: That's an impressive set of changes! Not only the changes of the 1.2 line, but also the 'CSA' to 'csa' bug fix and the __docformat__ = "plaintext" additions. As for the THETA and TC default values, I think these should be defined in the Ct default_value() method. The reason is because these defaults are almost never used (the only case I can think of is when optimisation occurs and there are no values yet set), they are duplicated in the docstring of that method hence it would be better to place them close to this, and they are not fixed constants but rough estimates. Regards, Edward On Jan 7, 2008 11:21 PM, <sebastien.morin.1@xxxxxxxxx> wrote: Author: semor Date: Mon Jan 7 23:21:28 2008 New Revision: 4468 URL: http://svn.gna.org/viewcvs/relax?rev=4468&view=rev Log: Modified the functions specific to consistency testing. This is not a simple copy of the jw mapping code anymore. Modified: branches/consistency_tests_1.3/specific_fns/consistency_tests.py [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/consistency_tests_1.3/specific_fns/consistency_tests.py URL: http://svn.gna.org/viewcvs/relax/branches/consistency_tests_1.3/specific_fns/consistency_tests.py?rev=4468&r1=4467&r2=4468&view=diff _______________________________________________ relax (http://nmr-relax.com) This is the relax-commits mailing list relax-commits@xxxxxxx To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-commits -- Sebastien Morin Etudiant au PhD en biochimie Laboratoire de resonance magnetique nucleaire Dr Stephane Gagne CREFSIP (Universite Laval, Quebec, CANADA) 1-418-656-2131 #4530