Hi,
I've now applied most of these patches. There were a few issues and I
have a few suggestions. Firstly for the commit messages, it's best to
use proper sentence structure with a capital letter at the start and
'.' at the end. As an aside, including as many links as possible to
mailing list messages, relax webpages, tasks, bug reports, etc is a
very good thing as it helps not only the person reading to easily jump
backwards and forwards to the relevant information, but it also helps
with increasing relax' rank in the search engines. Another issue is
that 'include_modelfree_logwindow_patch' included a os.sep fix!
Should have been separate. And finally, the tar file contained
'prepare_modelfree_calc_for_logwindow_patch', but no commit message
was given for this. I will wait until one is written to apply it.
Cheers,
Edward
2010/1/21 Michael Bieri <NO-REPLY.INVALID-ADDRESS@xxxxxxx>:
Follow-up Comment #23, task #6847 (project relax):
More patches.....
mkdir_patch:
replaced os.system('mkdir ' +.....) with os.mkdir()
--------------------------------------
import_logwindow_modules:
replaced modules for each calculation with log window modules
added:
from res.relax_control import start_rx, start_noe, start_modelfree
deleted:
from res.calc_noe import make_noe
from res.calc_rx import make_rx
from res.calc_modelfree import start_model_free
-------------------------------------------------------
include_modelfree_logwindow_patch:
included function to start model-free calculation from log windows and
control it
---------------------------------------------------------
open_log_window_after_startrelax_patch and
open_log_window_after_startrelax_modelfree_patch:
by pushing relax start button, log panel will be opened (and then
calculation
start subsequently).
replaced:
make_noe() to start_noe()
make_rx() to start_rx()
start_model_free() to start_modelfree()
----------------------------------------------------------
removed_closebox_patch:
closebox in mainwindow was removed to force output of reference
replaced:
kwds["style"] = wx.DEFAULT_FRAME_STYLE
to
kwds["style"] = wx.MINIMIZE_BOX | wx.SYSTEM_MENU | wx.CAPTION |
wx.CLIP_CHILDREN
------------------------------------------------------------
statusbar_size_patch:
size of statusbar (1st entry) was changed to get enought space to display
'repository checkout' in 3rd entry
---------------------------------------------------------------
This should be it for now!
Cheers
Michael
(file #7739)
_______________________________________________________
Additional Item Attachment:
File name: 100121_patches.tar.gz Size:4 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/task/?6847>
_______________________________________________
Nachricht geschickt von/durch Gna!
http://gna.org/
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-devel mailing list
relax-devel@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
Re: [task #6847] The Bieri graphical user interface.