Re: [task #7793] Speed-up of dispersion models -- May 28, 2014 - 12:11

Hi,

Do you have an example where infinite or NaN values appear?  I think
that with the 'No Rex' checks, we now 100% avoid these.  So I believe
that all Inf and NaN values came from the parameter values dw == 0.0
or pA == 1.0 or kex == 0.0 or phi_ex = 0.0 causing a failure in the
original dispersion equations.  That is what this patch demonstrates -
for all cases in the test suite, there is no longer any Inf or NaN
values :)  At least for the models we check for no exchange
conditions.

Regards,

Edward





On 28 May 2014 12:01, Troels Emtekær Linnet <tlinnet@xxxxxxxxxxxxx> wrote:
> Hi Edward.
>
> I cannot accept the patch.
>
> It removes all the isfinite(sum(R1rho)) tests I have put in.
>
> Best
> Troels
>
>
> 2014-05-28 11:53 GMT+02:00 Edward d  Auvergne
> <NO-REPLY.INVALID-ADDRESS@xxxxxxx>:
> > Follow-up Comment #86, task #7793 (project relax):
> >
> > I have modified the patch for the latest version of the disp_speed branch
> > (r23503).
> >
> > (file #20827)
> >     _______________________________________________________
> >
> > Additional Item Attachment:
> >
> > File name: patch_check_removal2           Size:10 KB
> >
> >
> >     _______________________________________________________
> >
> > Reply to this item at:
> >
> >   <http://gna.org/task/?7793>
> >
> > _______________________________________________
> >   Message sent via/by Gna!
> >   http://gna.org/