r25545 - /trunk/dep_check.py -- September 02, 2014 - 14:17

Author: bugman
Date: Tue Sep  2 14:17:50 2014
New Revision: 25545

URL: http://svn.gna.org/viewcvs/relax?rev=25545&view=rev
Log:
Another fix for the minfx version checking in the dep_check module.

The version_comparison() function has been created to perform a proper 
version number comparison by
stripping trailing zeros, converting the two version numbers to lists of int 
and comparing the lists
using the Python cmp() function.  This will return -1 when the version number 
is too low, 0 when the
versions are equal, and 1 when the version is higher than the minimum.


Modified:
    trunk/dep_check.py

Modified: trunk/dep_check.py
URL: 
http://svn.gna.org/viewcvs/relax/trunk/dep_check.py?rev=25545&r1=25544&r2=25545&view=diff
==============================================================================
--- trunk/dep_check.py  (original)
+++ trunk/dep_check.py  Tue Sep  2 14:17:50 2014
@@ -28,7 +28,38 @@
 # Python modules.
 import platform
 from os import F_OK, access, sep
+from re import sub
 import sys
+
+
+def version_comparison(version1, version2):
+    """Compare software versions.
+
+    This will return:
+
+        - When version 1 is older, -1,
+        - When both versions are equal, 0,
+        - When version 1 is newer, 1.
+
+
+    @param version1:    The first version number.
+    @type version1:     str
+    @param version2:    The second version number.
+    @type version2:     str
+    @return:            The comparison result of the Python cmp() function 
applied to two lists of integers.  This will be one of [-1, 0, 1].
+    @type return:       int
+    """
+
+    # Strip out trailing zeros.
+    version1 = sub(r'(\.0+)*$','', version1)
+    version2 = sub(r'(\.0+)*$','', version2)
+
+    # Convert to a list of numbers.
+    version1 = [int(val) for val in version1.split('.')]
+    version2 = [int(val) for val in version2.split('.')]
+
+    # Return the comparison.
+    return cmp(version1, version2)
 
 
 # Essential packages.
@@ -54,8 +85,8 @@
 # Minfx python package check.
 try:
     import minfx
-    ver = minfx.__version__.split('.')
-    if not (minfx.__version__ == 'trunk' or not (int(ver[0]) <= 1 and 
int(ver[1]) <= 0 and int(ver[2]) <= 9)):
+    min_version = '1.0.9'
+    if not minfx.__version__ == 'trunk' and 
version_comparison(minfx.__version__, min_version) == -1:
         sys.stderr.write("Version %s of the 'minfx' dependency is too old, 
minfx >= 1.0.9 is required.\n" % minfx.__version__)
         sys.exit()
 except ImportError: