mailr27193 - /trunk/gui/spin_viewer/tree.py


Others Months | Index by Date | Thread Index
>>   [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Header


Content

Posted by edward on January 15, 2015 - 10:25:
Author: bugman
Date: Thu Jan 15 10:25:36 2015
New Revision: 27193

URL: http://svn.gna.org/viewcvs/relax?rev=27193&view=rev
Log:
More robustness for the spin viewer GUI window update_*() methods.

The data returned from the self.tree.GetItemPyData(key) call can in rare 
racing cases not contain
the 'id' key.  This is now being checked for and are being skipped in the 
update_mol(), update_res()
and update_spin() methods.

The problem was found in the Mf.test_bug_20479_gui_final_pipe system test 
when running the command:
for i in {1..10}; do ./relax --gui-tests --time -d &>> gui_tests.log; done


Modified:
    trunk/gui/spin_viewer/tree.py

Modified: trunk/gui/spin_viewer/tree.py
URL: 
http://svn.gna.org/viewcvs/relax/trunk/gui/spin_viewer/tree.py?rev=27193&r1=27192&r2=27193&view=diff
==============================================================================
--- trunk/gui/spin_viewer/tree.py       (original)
+++ trunk/gui/spin_viewer/tree.py       Thu Jan 15 10:25:36 2015
@@ -933,7 +933,7 @@
             data = self.tree.GetItemPyData(key)
 
             # No info.
-            if data == None:
+            if data == None or 'id' not in data:
                 continue
 
             # Check the mol_id for a match and, if so, terminate to speed 
things up.
@@ -1010,7 +1010,7 @@
             data = self.tree.GetItemPyData(key)
 
             # No info.
-            if data == None:
+            if data == None or 'id' not in data:
                 continue
 
             # Check the res_id, res name, and res number for a match and, if 
so, terminate to speed things up.
@@ -1090,7 +1090,7 @@
             data = self.tree.GetItemPyData(key)
 
             # No info.
-            if data == None:
+            if data == None or 'id' not in data:
                 continue
 
             # Check the spin_id, spin name and spin number for a match and, 
if so, terminate to speed things up.




Related Messages


Powered by MHonArc, Updated Thu Jan 15 14:20:03 2015