That looks awesome, thank you for porting the code into the
conventions used in relax. The changes will significantly help with
the API docs, internal help system, etc. and will help standardise
these docs. I have to apologise for the tediousness of these
standards - I realise this is not what you would normally expect from
source code. The reason for these conventions is that I'm trying to
design the relax source code to be highly readable to allow NMR
spectroscopists, most of which are either not programmers or have just
a little programming experience, to be able to easily understand the
code and extend it's capabilities. The point is to lower the barrier
of entry into relax so that non-programmers can read the code and
mimic it to add features that they find useful. Because this is a
true open source project, many people will eventually read the code.
The number of people looking at the code is amplified by the fact the
users are NMR spectroscopists who are generally not afraid to dive
into code to find problems.
Anyway, back to the code. In the copyright notice you have your name
followed by 'https://gna.org/users'. I tried the link but it said
'Invalid user: that user doesn't exist'. It may be better to have the
link to 'https://gna.org/users/varioustoxins'. Once integrated into
relax, I think the 'get_startup_path()' can be dropped as
'sys.path[-1]' will give the same result. Although I don't have the
time to do this yet (I will find the time in the future), many of
these functions could be utilised by the system/function tests. In
the future they could possibly be shifted into a base class used by
both the unit and system/function tests. I'll look into this once I
attempt to migrate the system/function tests to use parts or all of
the unittest framework. At the moment though, we could simply have
relax run the unit tests followed by the system/function tests (or the
other way around). Each type of test could then return True or False
and relax could then print out (after printing all the other junk),
whether the unit tests passed, whether the system tests passed, and
then say that the test suite passed only if everything was ok. I'll
look into implementing this layer.
Thanks for this effort,
Edward
On 11/20/06, garyt@xxxxxxxxxxxxxxx <garyt@xxxxxxxxxxxxxxx> wrote:
Author: varioustoxins
Date: Mon Nov 20 11:16:15 2006
New Revision: 2860
URL: http://svn.gna.org/viewcvs/relax?rev=2860&view=rev
Log:
changes to bring code into line with relax code conventions
Modified:
branches/test_suite/test_suite/unit_tests/unit_test_runner.py
[This mail would be too long, it was shortened to contain the URLs only.]
Modified: branches/test_suite/test_suite/unit_tests/unit_test_runner.py
URL:
http://svn.gna.org/viewcvs/relax/branches/test_suite/test_suite/unit_tests/unit_test_runner.py?rev=2860&r1=2859&r2=2860&view=diff
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-commits mailing list
relax-commits@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-commits
Re: r2860 - /branches/test_suite/test_suite/unit_tests/unit_test_runner.py