mailMerging of the 'error_import' branch?


Others Months | Index by Date | Thread Index
>>   [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Header


Content

Posted by Edward d'Auvergne on March 02, 2007 - 06:27:
Hi,

Would anyone have an issue with the merging the 'error_import' branch
back into the 1.3 line?  The new code implements the ideas from the
'builtins' thread (see
https://mail.gna.org/public/relax-devel/2007-02/threads.html).
Firstly all of the data which was previously placed into __builtin__
has now been shifted either to the 'self.relax' instance or to the
global namespace of their respective modules (a lot of the __builtin__
references in the code were no longer used anyway).  Secondly the
RelaxError and RelaxWarning objects must now be imported into the
module requiring the error (as well as the unit test testing that that
error is triggered under the appropriate conditions).  This part will
cause breakages in the 1.3 line as these import statements are missing
from most modules.  The notation should look like:

from relax_errors import RelaxError, etc
from relax_warnings import RelaxWarning, etc

For some modules, which utilise many different error types, adding
these statements will be tedious.

Cheers,

Edward



Related Messages


Powered by MHonArc, Updated Fri Mar 02 08:20:21 2007