Edward d'Auvergne wrote:
Whoops, I stuffed that one up! I thought that 'module_path' was the
file system path to the module, i.e.
'./test_suite/unit_tests/data/test___init__.py', and that the split
statement was to remove the first dot and the '.py' at the end. I
should have read the code around it for context!
To clear up my confusion, is 'module_path' the full module name?
I thinks so but will have to check ;-)
Are
all the 'path' references in variable names the ``dotted module
names'', for example 'generic_fns.residue.create'? Is the
'offset_path' keyword argument of the 'get_first_instance_path()'
method referring to the current directory
definitley directores in this case. I will try and have a proper look at
whats going on tonight
or the module/package
seperator '.'? I'll go through tomorrow and fix all my mistakes.
Until then relax (the 1.3 line) should operate on all systems
excluding Mac OS 9.
Cheers,
Edward
Edward d'Auvergne wrote:
On 3/19/07, Gary S. Thompson <garyt@xxxxxxxxxxxxxxx> wrote:
edward@xxxxxxxxxxxxx wrote:
Hi Ed
Good to hear! I will take some time ot have a proper look through,
however, one thing struck me at a first look: consider line 115
components = module_path.split('.') components =
module_path.split(os.curdir)
for component in components[1:]: for component in
component in components[1:]:
This one is I believe wrong ;-( We are splitting a python path here (and
almost anywhere else you see a '.' used in split this will be the case)
This doesn't need to be replaced by os.curdir and would fail on older
mac for instance
regards
gary
>Author: bugman
>Date: Mon Mar 19 07:20:17 2007
>New Revision: 3234
>
>URL: http://svn.gna.org/viewcvs/relax?rev=3234&view=rev
>Log:
>Updated the unit test runner to be cross platform compatible.
>
>
>Modified:
> 1.3/test_suite/unit_tests/unit_test_runner.py
>
>Modified: 1.3/test_suite/unit_tests/unit_test_runner.py
>URL:
http://svn.gna.org/viewcvs/relax/1.3/test_suite/unit_tests/unit_test_runner.py?rev=3234&r1=3233&r2=3234&view=diff
>==============================================================================
>--- 1.3/test_suite/unit_tests/unit_test_runner.py (original)
>+++ 1.3/test_suite/unit_tests/unit_test_runner.py Mon Mar 19 07:20:17
2007
>@@ -115,7 +115,7 @@
>
[snip]
--
-------------------------------------------------------------------
Dr Gary Thompson
Astbury Centre for Structural Molecular Biology,
University of Leeds, Astbury Building,
Leeds, LS2 9JT, West-Yorkshire, UK Tel. +44-113-3433024
email: garyt@xxxxxxxxxxxxxxx Fax +44-113-2331407
-------------------------------------------------------------------
Re: r3234 - /1.3/test_suite/unit_tests/unit_test_runner.py