Re: r3261 - in /branches/multi_processor: generic_fns/ multi/ prompt/ specific_fns/ -- April 12, 2007 - 11:23

Gary,

I've had a look at the changes and I'm a little alarmed by the comment
'# these may need to be in c they cause an pprox 10% slowdown'.  What
is the 'multi/PrependStringIO.py' module actually used for?  There
isn't much in this module explaining its function.  If the slowdown is
during the minimisation, do we need to prepend 'S> ' and 'E> '?

In 'specific_fns/model_free.py' most of the changes where objects are
no longer placed into 'self' will be eliminated in the 1.3 line.  Most
class methods will probably be distributed into different modules
within the directory 'specific_fns/model_free/' and converted to
simple functions.  This will complicate the porting of the branch into
a patch for the 1.3 line.

On last thing is that I think that the changes to
'prompt/minimisation.py' belong elsewhere.  The call to
'self.relax.processor.run_queue()' should be in the generic code
(specifically 'generic_fns/minimisation.py') to allow any type of UI
to have access to the MPI code.  The code in the 'prompt/' directory
is solely used to set up the behaviour of the user functions
accessible through the prompt and script UIs, is used to test the
validity of the arguments and then execute the generic or specific
code.  Then if a graphical user interface (GUI) or some new UI is
added to relax, they will all automatically be MPI compatible.

Cheers,

Edward


On 4/8/07, garyt@xxxxxxxxxxxxxxx <garyt@xxxxxxxxxxxxxxx> wrote:
> Author: varioustoxins
> Date: Sat Apr  7 22:11:21 2007
> New Revision: 3261
>
> URL: http://svn.gna.org/viewcvs/relax?rev=3261&view=rev
> Log:
> Major update - monte carlo simulations supported (trivially)
> also implimented: chunky queues, exception throwing on slaves, and rank
> annotated output. note uniprocessor support currently broken.
>
> Added:
>     branches/multi_processor/multi/PrependStringIO.py
> Modified:
>     branches/multi_processor/generic_fns/minimise.py
>     branches/multi_processor/multi/commands.py
>     branches/multi_processor/multi/mpi4py_processor.py
>     branches/multi_processor/multi/processor.py
>     branches/multi_processor/prompt/minimisation.py
>     branches/multi_processor/specific_fns/model_free.py
>
> [This mail would be too long, it was shortened to contain the URLs only.]
>
> Modified: branches/multi_processor/generic_fns/minimise.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/generic_fns/minimise.py?rev=3261&r1=3260&r2=3261&view=diff
>
> Added: branches/multi_processor/multi/PrependStringIO.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/multi/PrependStringIO.py?rev=3261&view=auto
>
> Modified: branches/multi_processor/multi/commands.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/multi/commands.py?rev=3261&r1=3260&r2=3261&view=diff
>
> Modified: branches/multi_processor/multi/mpi4py_processor.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/multi/mpi4py_processor.py?rev=3261&r1=3260&r2=3261&view=diff
>
> Modified: branches/multi_processor/multi/processor.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/multi/processor.py?rev=3261&r1=3260&r2=3261&view=diff
>
> Modified: branches/multi_processor/prompt/minimisation.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/prompt/minimisation.py?rev=3261&r1=3260&r2=3261&view=diff
>
> Modified: branches/multi_processor/specific_fns/model_free.py
> URL: 
> http://svn.gna.org/viewcvs/relax/branches/multi_processor/specific_fns/model_free.py?rev=3261&r1=3260&r2=3261&view=diff
>
>
> _______________________________________________
> relax (http://nmr-relax.com)
>
> This is the relax-commits mailing list
> relax-commits@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-commits