mailRe: Typo in specific_fns/jw_mapping.py


Others Months | Index by Date | Thread Index
>>   [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Header


Content

Posted by Sébastien Morin on July 22, 2007 - 17:46:
Hi,

I just submitted the bug for the 1.3 line as well as a patch for it on the Gna
website.

Also, here is the patch for the trailing whitespaces.

This patch 'patch__specific_fns__jw_mapping__trailing_spaces__l1.2_r3342' 
fixes
a formating issue (trailing whitespaces) in the 1.2 line (revision 3342) for
the file 'specific_fns/jw_mapping.py'.

Cheers


Séb  :)



Selon Edward d'Auvergne <edward.dauvergne@xxxxxxxxx>, 22.07.2007:

Hi,

For this patch, there are a few things which I would do a little
differently.  Firstly the patch fixes a bug, so reporting this bug
before the patch is applied would help users of the program because if
they find the problem in the version they are using, they will then
know it's status.  Also because the bug occurs in the 1.3 line, it's
best if that line is patched.  I will then use the 'svnmerge' tool to
automatically port it back to the 1.2 line.  The whitespace change
should be separated as well as it is unrelated.

Cheers,

Edward


On 7/19/07, Sébastien Morin <sebastien.morin.1@xxxxxxxxx> wrote:
Hi

Here is a small patch (patch__jw_mapping__l1.2_r3342) correcting a typo in
the
file 'specific_fns/jw_mapping.py' where the string 'csa' was used instead
of
'r'. Also, some trailing whitespaces at line 249 are deleted for better
formating.

Cheers


Séb  :)
_______________________________________________
relax (http://nmr-relax.com)

This is the relax-devel mailing list
relax-devel@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel








------------------------
Sébastien Morin
Étudiant M.Sc. Biochimie
Laboratoire S. Gagné
3252 Pav. Marchand (Université Laval)
Tél : (418) 656-2131 #4530
Fax : (418) 656-7176
e-mail : sebastien.morin.1@xxxxxxxxx
Index: specific_fns/jw_mapping.py
===================================================================
--- specific_fns/jw_mapping.py  (revision 3342)
+++ specific_fns/jw_mapping.py  (working copy)
@@ -246,7 +246,7 @@
 
         # Loop over residue data:
         for residue in self.relax.data.res[run]:
-    
+
             # Check for sufficient data
             if not hasattr(residue, 'relax_data'):
                 residue.select = 0

Related Messages


Powered by MHonArc, Updated Sun Jul 22 18:20:54 2007