I just assumed incorrectly that the change was because 'J(0)' was
causing problems. In the tests I used a number of different
expressions to give better coverage and a better chance for catching
bugs. But in reality the unit tests of the return_data_name() method
should cover and test all possible combinations, I just need to write
them. So, please ignore my previous message.
Cheers,
Edward
On Jan 8, 2008 11:41 PM, Sebastien Morin <sebastien.morin.1@xxxxxxxxx> wrote:
Hi,
Did you find a bug with that test using 'J(0)' instead of 'j0' ? I haven't
seen one, but just wanted to correct this expression so the code is uniform
(same way to use expressions between different tests)...
Cheers
Séb
Edward d'Auvergne wrote:
According to the docstring, the string 'J(0)' should be acceptable by
the return_data_name() method. This test uncovered a bug in the
function rather than a typo in the test itself. Maybe this has
something to do with regular expression and the '\' character in front
of the brackets?
Regards,
Edward
On Jan 8, 2008 11:16 PM, <sebastien.morin.1@xxxxxxxxx> wrote:
Author: semor
Date: Tue Jan 8 23:16:21 2008
New Revision: 4514
URL: http://svn.gna.org/viewcvs/relax?rev=4514&view=rev
Log:
Corrected a typo.
Modified:
branches/consistency_tests_1.3/test_suite/unit_tests/value_testing_base.py
Modified:
branches/consistency_tests_1.3/test_suite/unit_tests/value_testing_base.py
URL:
http://svn.gna.org/viewcvs/relax/branches/consistency_tests_1.3/test_suite/unit_tests/value_testing_base.py?rev=4514&r1=4513&r2=4514&view=diff
==============================================================================
---
branches/consistency_tests_1.3/test_suite/unit_tests/value_testing_base.py
(original)
+++
branches/consistency_tests_1.3/test_suite/unit_tests/value_testing_base.py
Tue Jan 8 23:16:21 2008
@@ -299,7 +299,7 @@
cdp = relax_data_store[relax_data_store.current_pipe]
# Set the parameter.
- self.value_fns.set(param=['J(0)', 'f_eta', 'f_r2'], val=1.9e-10)
+ self.value_fns.set(param=['j0', 'f_eta', 'f_r2'], val=1.9e-10)
# Test the parameter.
self.assertEqual(cdp.mol[0].res[0].spin[0].j0, 1.9e-10)
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-commits mailing list
relax-commits@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-commits
--
Sebastien Morin
Etudiant au PhD en biochimie
Laboratoire de resonance magnetique nucleaire
Dr Stephane Gagne
CREFSIP (Universite Laval, Quebec, CANADA)
1-418-656-2131 #4530
Re: r4514 - /branches/consistency_tests_1.3/test_suite/unit_tests/value_testing_base.py