Re: r5594 - /1.3/specific_fns/jw_mapping.py -- April 12, 2008 - 02:00

Hi Ed,

Thanks for spotting this for me.

Have a nice weekend !


Séb



Edward d'Auvergne wrote:

Seb,

In response to your message at
https://mail.gna.org/public/relax-devel/2008-04/msg00033.html, the
changes you have made in this revision (r5594) are almost correct.
The set_error() method previously took both the 'instance' and 'index'
arguments (but in r5251 you changed 'index' to 'spin').  Looking at
the code in the method, it requires the parameter 'index' argument.
So the main code of the function is fine, but the arguments need to be
set_error(self, spin, index, error).  Once I add epydoc argument
descriptions (fields: http://epydoc.sourceforge.net/epytext.html), the
purpose and type of each argument should become much clearer.  Adding
epydoc fields to all functions and methods will take me a very long
time though.  I will also try to refine the specific_fns API and maybe
have a base class with stub methods describing or prototyping each
method of the API.  These stubs will show what goes into one of these
functions and what should come out - this should help in adding new
analyses to relax (like the consistency test code, although it's a bit
late to be of use for that).

Cheers,

Edward


On Fri, Apr 11, 2008 at 8:43 PM,  <sebastien.morin.1@xxxxxxxxx> wrote:
  

Author: semor
 Date: Fri Apr 11 20:43:28 2008
 New Revision: 5594

 URL: http://svn.gna.org/viewcvs/relax?rev=5594&view=rev
 Log:
 Converted some 'instance' arguments to calls to 'spin' and removed some now unused 'cdp' calls.

 This is a small part of what Edward d'Auvergne noticed in a post at:
 https://mail.gna.org/public/relax-devel/2008-04/msg00010.html (# Message-id:
 <7f080ed10804030909m3b540ee3y1d60009542c09694@xxxxxxxxxxxxxx>)


 Modified:
    1.3/specific_fns/jw_mapping.py

 Modified: 1.3/specific_fns/jw_mapping.py
 URL: http://svn.gna.org/viewcvs/relax/1.3/specific_fns/jw_mapping.py?rev=5594&r1=5593&r2=5594&view=diff
 ==============================================================================
 --- 1.3/specific_fns/jw_mapping.py (original)
 +++ 1.3/specific_fns/jw_mapping.py Fri Apr 11 20:43:28 2008
 @@ -402,23 +402,20 @@
         cdp.jw_frq = frq


 -    def set_error(self, instance, spin, error):
 +    def set_error(self, spin, error):
         """Function for setting parameter errors."""
 -
 -        # Alias the current data pipe.
 -        cdp = relax_data_store[relax_data_store.current_pipe]

         # Return J(0) sim data.
         if index == 0:
 -            cdp.res[instance].j0_err = error
 +            spin.j0_err = error

         # Return J(wX) sim data.
         if index == 1:
 -            cdp.res[instance].jwx_err = error
 +            spin.jwx_err = error

         # Return J(wH) sim data.
         if index == 2:
 -            cdp.res[instance].jwh_err = error
 +            spin.jwh_err = error


     def sim_return_param(self, instance, index):


 _______________________________________________
 relax (http://nmr-relax.com)

 This is the relax-commits mailing list
 relax-commits@xxxxxxx

 To unsubscribe from this list, get a password
 reminder, or change your subscription options,
 visit the list information page at
 https://mail.gna.org/listinfo/relax-commits

    

_______________________________________________
relax (http://nmr-relax.com)

This is the relax-devel mailing list
relax-devel@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel