Re: r7012 - /1.3/dep_check.py -- July 29, 2008 - 16:07

Hi Ed,

I wasn't aware of the relax_io.test_binary() function which is better
than what I proposed for testing the presence of the ModelFree4 executable.

I will revert r7012 as your proposal of r7017
(http://svn.gna.org/viewcvs/relax?rev=7017&view=rev) is far better, I think.

As for the reason why I wanted this test, it is to complement the
'palmer' system tests which, for real interaction with ModelFree4 stuff,
should be present to verify the quality of this code part more easily.

Regards,


Séb




Edward d'Auvergne wrote:
> Hi,
>
> I'm not sure if this test is the best option.  I have already written
> a function called 'relax_io.test_binary' which is usually run prior to
> the execution of any of the external programs relax can control
> (Modelfree4, Dasha, PyMOL, Molmol, VMD, Xmgrace, and OpenDX).  This
> function raises RelaxErrors dependent upon different problems
> associated with the binary file.  Currently the user can, through
> relax, specify a binary that's not located in the system path.  So if
> we automatically test for all these executable binary files, then we
> would need to make the decision that the user must have all these
> programs located in the system path.  There would be a benefit in
> having flags identifying the presence of these programs, but the
> downside is that flexibility for the user is removed.  Was there a
> specific reason for adding this test?
>
> Regards,
>
> Edward
>
>
> On Mon, Jul 28, 2008 at 10:35 PM,  <sebastien.morin.1@xxxxxxxxx> wrote:
>   
> > Author: semor
> > Date: Mon Jul 28 22:35:00 2008
> > New Revision: 7012
> >
> > URL: http://svn.gna.org/viewcvs/relax?rev=7012&view=rev
> > Log:
> > Added a check for the optionnal Modelfree4 program.
> >
> > This check doesn't return a clean warning and should be improved.
> >
> >
> > Modified:
> >    1.3/dep_check.py
> >
> > Modified: 1.3/dep_check.py
> > URL: 
> > http://svn.gna.org/viewcvs/relax/1.3/dep_check.py?rev=7012&r1=7011&r2=7012&view=diff
> > ==============================================================================
> > --- 1.3/dep_check.py (original)
> > +++ 1.3/dep_check.py Mon Jul 28 22:35:00 2008
> > @@ -28,7 +28,7 @@
> >
> >  # Python modules.
> >  import platform
> > -from os import F_OK, access, sep
> > +from os import F_OK, access, popen, sep
> >  import sys
> >
> >
> > @@ -106,6 +106,9 @@
> >  except ImportError:
> >     scientific_pdb_module = False
> >
> > +# Modelfree4.
> > +modelfree4 = popen("which modelfree4")
> > +del modelfree4
> >
> >  # Compiled C modules.
> >  #####################
> >
> >
> > _______________________________________________
> > relax (http://nmr-relax.com)
> >
> > This is the relax-commits mailing list
> > relax-commits@xxxxxxx
> >
> > To unsubscribe from this list, get a password
> > reminder, or change your subscription options,
> > visit the list information page at
> > https://mail.gna.org/listinfo/relax-commits
> >
> >     
>
> _______________________________________________
> relax (http://nmr-relax.com)
>
> This is the relax-devel mailing list
> relax-devel@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel
>
>