Re: r8556 - /branches/multi_structure/specific_fns/model_free/main.py -- January 22, 2009 - 09:36

I was ripping my hair out trying to find this one.  I couldn't for the
life of me work out why I was loosing the data for all spins except
the first, when the changes to the code had to do with structures,
i.e. nothing to do with the spins and their data structures!
Grrrr....

Bye,

Edward


On Thu, Jan 22, 2009 at 5:23 AM, Sébastien Morin
<sebastien.morin.1@xxxxxxxxx> wrote:
> Hi Ed,
>
> You shouldn't use such nasty words... :p
>
> (Just joking !)
>
> Seriously, how did you find this bug ?????
>
>
> Séb  :)
>
>
>
>
> Selon edward@xxxxxxxxxxxxx, 21.01.2009:
>
> > Author: bugman
> > Date: Wed Jan 21 17:53:00 2009
> > New Revision: 8556
> >
> > URL: http://svn.gna.org/viewcvs/relax?rev=8556&view=rev
> > Log:
> > Found and fixed the biggest pain in the ass bug ever (after 2 days of
> > debugging)!
> >
> > The model-free model index 'model_index' which was being passed into
> > duplicate_data() was being
> > overwritten by the loop over structural models, which was also using
> > 'model_index'!!!
> >
> >
> > Modified:
> >     branches/multi_structure/specific_fns/model_free/main.py
> >
> > Modified: branches/multi_structure/specific_fns/model_free/main.py
> > URL:
> http://svn.gna.org/viewcvs/relax/branches/multi_structure/specific_fns/model_free/main.py?rev=8556&r1=8555&r2=8556&view=diff
> > ==============================================================================
> > --- branches/multi_structure/specific_fns/model_free/main.py (original)
> > +++ branches/multi_structure/specific_fns/model_free/main.py Wed Jan 21
> > 17:53:00 2009
> > @@ -1137,10 +1137,10 @@
> >                      raise RelaxError, "The number of structural models is
> > not consistent between the pipes " + `pipe_from` + " and " + `pipe_to` + 
> > "."
> >
> >                  # Loop over the models.
> > -                for model_index in
> > range(len(dp_from.structure.structural_data)):
> > +                for i in range(len(dp_from.structure.structural_data)):
> >                      # Alias.
> > -                    model_from =
> > dp_from.structure.structural_data[model_index]
> > -                    model_to = 
> > dp_to.structure.structural_data[model_index]
> > +                    model_from = dp_from.structure.structural_data[i]
> > +                    model_to = dp_to.structure.structural_data[i]
> >
> >                      # Model numbers.
> >                      if model_from.num != model_to.num:
> >
> >
> > _______________________________________________
> > relax (http://nmr-relax.com)
> >
> > This is the relax-commits mailing list
> > relax-commits@xxxxxxx
> >
> > To unsubscribe from this list, get a password
> > reminder, or change your subscription options,
> > visit the list information page at
> > https://mail.gna.org/listinfo/relax-commits
>
>
>
> ------------------------
> Sébastien Morin
> Étudiant M.Sc. Biochimie
> Laboratoire S. Gagné
> 3252 Pav. Marchand (Université Laval)
> Tél : (418) 656-2131 #4530
> Fax : (418) 656-7176
> e-mail : sebastien.morin.1@xxxxxxxxx
>
>
> _______________________________________________
> relax (http://nmr-relax.com)
>
> This is the relax-devel mailing list
> relax-devel@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel