mailRe: [bug #13162] Rex values in XML results file not in s-1


Others Months | Index by Date | Thread Index
>>   [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Header


Content

Posted by Edward d'Auvergne on March 12, 2009 - 17:22:
[snip]

2.
The results file could have the Rex value in s-1 associated to a specific
magnetic field so users can more easily think of the effect on the
experimental R2.


Unfortunately the ability to convert this value is missing from the
XML infrastructure.  This will require much more work, and hence
option 1 might be best.  But it is obvious from any of the results
files that all of the units (te, CSA, etc.) are wrong!  The code is in
the return_data_desc() method of specific_fns/model_free/main.py, if
you would like to try to fix it.

I can take care of this.

I will change units in function return_units() to SI units (meters,
seconds, etc).

Just a few questions.

1.
In function return_units(), the CSA units are currently in ppm. Once
this is corrected, the CSA should be unitless, right ?

Yes.  It might be worth having '(unitless)' in the string to make this clear.


2.
In function return_grace_string() of specific_fns/model_free/main.py,
should "Rex" be changed to "sigma_ex = Rex / omega**2" as well ?

Ah, the code that uses this will have the Rex value and not sigma_ex.
So this is not necessary.


3.
In function return_conversion_factor(), should values and/or units be
changed as well ?

No, this code is correct.  If the XML code could support it, it would
use this function to convert to ppm, Rex from sigma_ex, ps, etc.

Cheers,

Edward



Related Messages


Powered by MHonArc, Updated Thu Mar 12 18:20:27 2009