Re: r10915 - /branches/bieri_gui/gui_bieri/analyses/auto_rx_base.py -- February 25, 2010 - 10:12

Hi,

If this is the purpose, to change the output file name, then I am
happy with that :)  It was not obvious that there was a purpose.  What
about an alternative - that output file name is an argument "out_file"
that defaults to "rx.out".  The GUI can then override this and pass in
the arg "out_file='R1.600.out'".  What do you think?

Cheers,

Edward


On 25 February 2010 10:06, Michael Bieri <michael.bieri@xxxxxx> wrote:
> Hi Edward
>
> I strongly recommend to keep this modifications. This is to avoid a mess
> of data parameter files that are all named the same was (noe.out x3,
> rx.our x3...). This is just cosmetics but improves the organization a
> lot. What do you think about?
>
> Cheers
>
>
> Edward d'Auvergne schrieb:
> > Hi Michael,
> >
> > This change is not necessary as the script doesn't use this
> > information.  Neither field strength nor the fact that is either R1,
> > R2, etc. matters.  Therefore I suggest you revert this by typing:
> >
> > $ svn merge -r10915:10914 .
> > $ svn ci -F svnmerge-commit-message.txt
> >
> > This is how you remove a commit.  In the commit message, you MUST
> > specify the svn command used (for essential tracking purposes), and
> > point to this message when archived at
> > https://mail.gna.org/public/relax-devel/.
> >
> > Cheers,
> >
> > Edward
> >
> >
> >
> >
> > On 25 February 2010 03:38,  <michael.bieri@xxxxxx> wrote:
> >
> > > Author: michaelbieri
> > > Date: Thu Feb 25 03:38:23 2010
> > > New Revision: 10915
> > >
> > > URL: http://svn.gna.org/viewcvs/relax?rev=10915&view=rev
> > > Log:
> > > The type of Rx calculation (R1 or R2) as well as the current frequency 
> > > will be sent to the relax_fit.py script.
> > >
> > > Modified:
> > >    branches/bieri_gui/gui_bieri/analyses/auto_rx_base.py
> > >
> > > Modified: branches/bieri_gui/gui_bieri/analyses/auto_rx_base.py
> > > URL: 
> > > http://svn.gna.org/viewcvs/relax/branches/bieri_gui/gui_bieri/analyses/auto_rx_base.py?rev=10915&r1=10914&r2=10915&view=diff
> > > ==============================================================================
> > > --- branches/bieri_gui/gui_bieri/analyses/auto_rx_base.py (original)
> > > +++ branches/bieri_gui/gui_bieri/analyses/auto_rx_base.py Thu Feb 25 
> > > 03:38:23 2010
> > > @@ -388,7 +388,7 @@
> > >         data = self.assemble_data()
> > >
> > >         # Execute.
> > > -        Relax_fit(seq_args=data.seq_args, file_names=data.file_names, 
> > > relax_times=data.relax_times, int_method=data.int_method, 
> > > mc_num=data.mc_num, pdb_file = data.structure_file, unresolved = 
> > > data.unresolved)
> > > +        Relax_fit(rx_type = self.label[1], freq = data.frq, 
> > > seq_args=data.seq_args, directory = data.save_dir, 
> > > file_names=data.file_names, relax_times=data.relax_times, 
> > > int_method=data.int_method, mc_num=data.mc_num, pdb_file = 
> > > data.structure_file, unresolved = data.unresolved)
> > >
> > >
> > >     def link_data(self, data):
> > >
> > >
> > > _______________________________________________
> > > relax (http://nmr-relax.com)
> > >
> > > This is the relax-commits mailing list
> > > relax-commits@xxxxxxx
> > >
> > > To unsubscribe from this list, get a password
> > > reminder, or change your subscription options,
> > > visit the list information page at
> > > https://mail.gna.org/listinfo/relax-commits
> >
> > _______________________________________________
> > relax (http://nmr-relax.com)
> >
> > This is the relax-devel mailing list
> > relax-devel@xxxxxxx
> >
> > To unsubscribe from this list, get a password
> > reminder, or change your subscription options,
> > visit the list information page at
> > https://mail.gna.org/listinfo/relax-devel
>
> _______________________________________________
> relax (http://nmr-relax.com)
>
> This is the relax-devel mailing list
> relax-devel@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel