Hi,
That would be good, reverting all of these. The idea with having this
clean API between the two is to hide the implementation of either side
(GUI or auto-analysis) from the other. The API is how they talk to
each other, one asks, the other gives. What the auto-analysis does
with the given values is inconsequential for the GUI. But there are
at times situations where the current API does not provide all that is
needed. So we have to expand the API to handle this. If you need
more from the API, like adding a results directory, that argument can
be added (expansion of the API). The auto-analysis then decides what
to do with this. For each API change, it would be useful to discuss
this first. The reason is because there might be better, more
efficient, or less API damaging ways of doing this.
So in this case, I would like the auto-analyses side of the API
developed in the 1.3 line, and the GUI side developed in the bieri_gui
branch. This allows the sample scripts to use this API as well and,
in the future, a branch for the web interface can also have access.
I'm guessing you have a auto-analysis module for the NOE as the
current code I have is not functional and is asking for it! Could you
attach this to the task so I can add it to the 1.3 line? And is it a
copy from another file in relax, i.e. the NOE sample script?
Cheers,
Edward
On 26 February 2010 00:18, Michael Bieri <michael.bieri@xxxxxx> wrote:
I will revert all the modifications of the auto_analysis protocols. The
idea to add savefile = 'rx' to the automatic protocols, which can be
controlled by the GUI sounds to be a good solution! Do you change the
relax_fit.py script for this?
Edward d'Auvergne schrieb:
Hi Michael,
Could you please first revert this commit and then provide it as a
patch file? This should be committed directly into the 1.3 line, not
in the bieri_gui branch.
Cheers,
Edward
On 25 February 2010 05:39, <michael.bieri@xxxxxx> wrote:
Author: michaelbieri
Date: Thu Feb 25 05:39:28 2010
New Revision: 10923
URL: http://svn.gna.org/viewcvs/relax?rev=10923&view=rev
Log:
Current date was added to pipe name to allow multiple rx calculations
during the same session.
Modified:
branches/bieri_gui/auto_analyses/relax_fit.py
Modified: branches/bieri_gui/auto_analyses/relax_fit.py
URL:
http://svn.gna.org/viewcvs/relax/branches/bieri_gui/auto_analyses/relax_fit.py?rev=10923&r1=10922&r2=10923&view=diff
==============================================================================
--- branches/bieri_gui/auto_analyses/relax_fit.py (original)
+++ branches/bieri_gui/auto_analyses/relax_fit.py Thu Feb 25 05:39:28 2010
@@ -47,7 +47,7 @@
"""
# Store the args.
- self.pipe_name = pipe_name
+ self.pipe_name = pipe_name+ ' ' +
str(time.asctime(time.localtime())) # add date and time to allow multiple
executions of relax_fit
self.seq_args = seq_args
self.file_names = file_names
self.relax_times = relax_times
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-commits mailing list
relax-commits@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-commits
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-devel mailing list
relax-devel@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-devel mailing list
relax-devel@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
Re: r10923 - /branches/bieri_gui/auto_analyses/relax_fit.py