Re: [sr #3043] Support for NMRPipe seriesTab format *.ser -- June 26, 2013 - 15:25

Hi Edward.

Just see this as a test round. :-)

Most important is, that you can read these patch files.
In each patch, is also stored the commit message, which I
hope should be auto-read as well.

I covered how it is possible to change the commit message.
I haven't tested yet, how it is possible to change the code commit.

I guess that you rebase and amend commit. (Another option than "r")
git rebase -i HEAD~2


The most problematic thing for me, was the understanding of the need to
create a branch from master. Add files. Create a new branch from the
just created branch.
Then change files.
Then do a "git format-patch PREVBRANCH"

It's all about creating a lot of small branches, for each development step.
Merging, deleting them, comparing between them.

Best
Troels Emtekær Linnet


2013/6/26 Edward d'Auvergne <edward@xxxxxxxxxxxxx>:
> Hi Troels,
>
> Would you be able to upload the patch either as the five original
> files or at least in a different format.  On the Linux system I am
> using, I am currently unable to open RAR files.  If you could use zip
> or tar.gz, that would be much better.  On another note, why are there
> 5 patches and one commit message?  The implementation of the function
> in lib.software.nmrpipe should only require one patch.  Once I can
> read them, I'll start with the feedback.  I may be able to do this
> tomorrow before I go on holidays next week.  Also, I was wondering if
> you know how to use git to change the contents of a commit, as that
> should be possible?
>
> Cheers,
>
> Edward
>
>
> On 25 June 2013 19:06, Troels E. Linnet
> <NO-REPLY.INVALID-ADDRESS@xxxxxxx> wrote:
> > Follow-up Comment #33, sr #3043 (project relax):
> >
> > Completed NMRPipe SeriesTab reader for assignment according to SPARKY 
> > format.
> >
> > Progress sr #3043: (https://gna.org/support/index.php?3043) Support for
> > NMRPipe seriesTab format *.ser
> >
> > Multiple spectra and intensity reading for NMRPipe SeriesTab formatted file
> > completed.
> >
> > -----------
> > Zip file with 5 patches added
> >
> > Completed according to:
> > http://nmr-relax.kimlinnet.dk/index.php?title=Git_asynchronous_development#Complete_test_suite
> >
> > Patches should be applied with:
> > patch -p1 -i 
> > 0001-Imported-the-expected-used-modules-in-lib.software.n.patch
> >
> > patch -p1 -i 
> > 0002-Imported-the-expected-used-modules-in-lib.software.n.patch
> >
> >
> >
> > (file #18166)
> >     _______________________________________________________
> >
> > Additional Item Attachment:
> >
> > File name: seriestab_patches_v1.rar       Size:4 KB
> >
> >
> >     _______________________________________________________
> >
> > Reply to this item at:
> >
> >   <http://gna.org/support/?3043>
> >
> > _______________________________________________
> >   Message sent via/by Gna!
> >   http://gna.org/
> >
> >
> > _______________________________________________
> > relax (http://www.nmr-relax.com)
> >
> > This is the relax-devel mailing list
> > relax-devel@xxxxxxx
> >
> > To unsubscribe from this list, get a password
> > reminder, or change your subscription options,
> > visit the list information page at
> > https://mail.gna.org/listinfo/relax-devel