Re: [sr #3071] Implementation of Tollinger/Kay dispersion model (2001) -- September 09, 2013 - 18:33

Hi,

I have applied the patches.  Some comments:

0001 - The assertAlmostEqual() call with zero or -1 does not do
anything.  I would suggest you divide all numbers by 10, then set the
significant figures to 1.  There was also some trailing whitespace,
according to git-svn.

The other patches were all fine :)

Regards,

Edward



On 9 September 2013 17:17, Troels E. Linnet
<NO-REPLY.INVALID-ADDRESS@xxxxxxx> wrote:
> Follow-up Comment #57, sr #3071 (project relax):
>
> Added new 1.01 M Gua HCl dataset.
> The one mentioned in the figure 2 in the article.
>
> System-test re-written.
>
> The k_AB also now fit for the 0.48 M GuaHCl dataset, after
> calculating k_AB from figure 3, where it is shown as ln(k_AB) for all the
> different Gua HCl concentrations.
>
> (file #18942)
>     _______________________________________________________
>
> Additional Item Attachment:
>
> File name: 101MGuaHCl_dataset.patch.tar.gz Size:153 KB
>
>
>     _______________________________________________________
>
> Reply to this item at:
>
>   <http://gna.org/support/?3071>
>
> _______________________________________________
>   Message sent via/by Gna!
>   http://gna.org/