Re: [sr #3071] Implementation of Tollinger/Kay dispersion model (2001) -- September 13, 2013 - 14:54

Ok, patches 0008, 0009, and 0010 applied cleanly to trunk and they are
now merged back to the branch.

Cheers,

Edward



On 13 September 2013 14:49, Edward d'Auvergne <edward@xxxxxxxxxxxxx> wrote:
> Hi,
>
> > Regarding pathches
> > 3-6
> > I cannot use svn copy.
> > So I will not do anything to them.
>
> For that, just request the change with a commit message, and I can do
> that.  Once you have commit access, you can do this with a svn checked
> copy (used only for such changes, if you wish to continue with git).
>
>
> > Can you apply
> > 0008,0009,0010 to trunk and merge into disp branch?
> > These are errors in the bibtex files, which make bibtex complain.
>
> I'll try, but they are designed for the branch so I don't know if
> they'll apply due to line numbering mismatches.  Let's see.
>
>
> > Regarding 0012
> > I will fix the indention.
>
> Cheers.
>
>
> > Rearding 0016
> > I will redo after the last commit.
>
> Ok.
>
>
> > Regarding 0018.
> > Just ignore it, if don't think it should be applied.
> > I would prefer if the manual would state a section with parameters
> > start values, their minimum and maximum limits for the linear
> > constraints, and
> > a little section on how the grid_search part the search space up. An
> > explanation to the 'grid_inc' parameter.
>
> Again there no starting values, only a grid search.  So a table of
> starting values is misleading.  The 'default' values will really never
> be seen by a relax user.  Anyway, if you don't think this table is
> useful, I won't add it.
>
>
> > Patch 22 is a type fix for 15.
> > I should have squashed that fix into 15. I will redo it.
>
> Oh, you mean a typo :)  Ok.
>
> Cheers,
>
> Edward