Re: [sr #3044] Load spins from SPARKY list. -- December 07, 2013 - 12:23

Hi,

I have thought about that before, but they are sufficiently different
to warrant having different code for each.  It allows for future
flexibility as well.  I have tried the merger before, many years ago,
but it failed miserably due to the small differences between the
files, especially if you move to 3D and higher.  You can give it a go
if you wish, but it's probably not worth the effort.  As long as we
have full test suite coverage, then we will know that the code is
fully functional for all time, so I don't see a pressing need to
change this.

Regards,

Edward



On 6 December 2013 20:00, Troels Emtekær Linnet <tlinnet@xxxxxxxxxxxxx> wrote:
> Hi.
>
> It is:
> /lib/spectrum
> nmrpipe.py
> nmrview.py
> sparky.py
> xeasy.py
>
> It is the chemical shift part.
> The checking of intensity
> And return of values.
>
> The structures are very similar.
>
> Best
> Troels
>
> 2013/12/6 Edward d'Auvergne <edward@xxxxxxxxxxxxx>:
> > Hi,
> >
> > Could you give an example of the code replication or point to where it is?
> >
> > Cheers,
> >
> > Edward
> >
> >
> >
> > On 6 December 2013 19:32, Troels E. Linnet
> > <NO-REPLY.INVALID-ADDRESS@xxxxxxx> wrote:
> > > Follow-up Comment #4, sr #3044 (project relax):
> > >
> > > Hi Edward.
> > >
> > > Some of the code is quite much replicated.
> > >
> > > Should one create another file with shared functions, which is repeated
> > > in the files, or just leave it as it is?
> > >
> > >     _______________________________________________________
> > >
> > > Reply to this item at:
> > >
> > >   <http://gna.org/support/?3044>
> > >
> > > _______________________________________________
> > >   Message sent via/by Gna!
> > >   http://gna.org/