Re: r22416 - /trunk/test_suite/unit_tests/_specific_analyses/_relax_disp/test_disp_data.py -- March 06, 2014 - 17:56

Hi Troels,

For a unit test, the best practice is to never use other parts of
relax.  This can make the code a lot longer, but the independence is
very important.  When this unit test fails, it must be because of a
problem with the return_offset_data() function.  It cannot fail due to
problems with the return_param_key_from_data() function.  Unit tests
need to be stand alone and independent, this is very important for
their function.  Can you see a way of implementing what you need
without calling the return_param_key_from_data() function?

Cheers,

Edward




On 6 March 2014 17:28,  <tlinnet@xxxxxxxxxxxxx> wrote:
> Author: tlinnet
> Date: Thu Mar  6 17:28:21 2014
> New Revision: 22416
>
> URL: http://svn.gna.org/viewcvs/relax?rev=22416&view=rev
> Log:
> Imported return_param_key_from_data to be used in unit test 
> return_offset_data.
>
> Regarding sr #3124, (https://gna.org/support/index.php?3124) - Grace graphs 
> production for R1rho analysis with R2_eff as function of Omega_eff.
>
> Modified:
>     
> trunk/test_suite/unit_tests/_specific_analyses/_relax_disp/test_disp_data.py
>
> Modified: 
> trunk/test_suite/unit_tests/_specific_analyses/_relax_disp/test_disp_data.py
> URL: 
> http://svn.gna.org/viewcvs/relax/trunk/test_suite/unit_tests/_specific_analyses/_relax_disp/test_disp_data.py?rev=22416&r1=22415&r2=22416&view=diff
> ==============================================================================
> --- 
> trunk/test_suite/unit_tests/_specific_analyses/_relax_disp/test_disp_data.py
>         (original)
> +++ 
> trunk/test_suite/unit_tests/_specific_analyses/_relax_disp/test_disp_data.py
>         Thu Mar  6 17:28:21 2014
> @@ -29,7 +29,7 @@
>  from pipe_control import state
>  from pipe_control.mol_res_spin import get_spin_ids, return_spin
>  from specific_analyses.relax_disp.checks import get_times
> -from specific_analyses.relax_disp.disp_data import count_relax_times, 
> find_intensity_keys, get_curve_type, has_exponential_exp_type, 
> loop_exp_frq, loop_exp_frq_offset, loop_exp_frq_offset_point, 
> loop_exp_frq_offset_point_time, loop_time, return_offset_data, 
> return_spin_lock_nu1
> +from specific_analyses.relax_disp.disp_data import count_relax_times, 
> find_intensity_keys, get_curve_type, has_exponential_exp_type, 
> loop_exp_frq, loop_exp_frq_offset, loop_exp_frq_offset_point, 
> loop_exp_frq_offset_point_time, loop_time, return_offset_data, 
> return_param_key_from_data, return_spin_lock_nu1
>  from status import Status; status = Status()
>  from test_suite.unit_tests.base_classes import UnitTestCase
>
>
>
> _______________________________________________
> relax (http://www.nmr-relax.com)
>
> This is the relax-commits mailing list
> relax-commits@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-commits