Re: [bug #22055] The processor.run_queue() does not clean up in uni_processor? -- May 20, 2014

Hi Ed.

I tried hard for several hours yesterday.

But this multi-processing goes beyond my skills...

If you know a little more about, and can fix it, I would be very happy.

I can try the thing you suggested, but beyond that, I would be lost.

Best
Trpels

2014-05-20 9:43 GMT+02:00 Edward d'Auvergne <edward@xxxxxxxxxxxxx>:

Hi Troels,

You might have actually have found the source of the problem!  This
has been an issue for a long time, but I never solved it.  It affects
many analysis types and I have always wondered why one failing test
would cause many subsequent tests of the same analysis type to fail.
This has been around longer than the dispersion analysis which was
started in 2009.  I always tried to solve it in the special
self.tearDown() test suite method for cleaning up after tests, but
this somehow never completely solved the issue.  So it could have
something to do with the FIXME comment in the run_queue() method of
the multi.uni_processor module:


    def run_queue(self):
        #FIXME: need a finally here to cleanup exceptions states for 
windows etc

        last_command = len(self.command_queue)-1
        for i, command  in enumerate(self.command_queue):
            completed = (i == last_command)

            command.run(self, completed)

        #self.run_command_queue()
        #TODO: add cheques for empty queues and maps if now warn
        del self.command_queue[:]
        self.memo_map.clear()


There are a few minor FIXMEs and TODOs in Gary Thompson's
multi-processor framework.  But this one might be quite important for
the test suite.  You could try as the FIXME says, add a 'try-finally'
statements so the last two lines are always run.  This may cause other
issues, so be careful.

Note, this must not be committed to your 'disp_speed' branch.  If you
have a fix, make sure it is applied to the trunk.

Cheers,

Edward





On 20 May 2014 02:04, Troels E. Linnet <NO-REPLY.INVALID-ADDRESS@xxxxxxx> 
wrote:

Additional Item Attachment, bug #22055 (project relax):

File name: log.txt                        Size:792 KB


    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?22055>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
relax-devel@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel

Re: [bug #22055] The processor.run_queue() does not clean up in uni_processor?

Header

Content

Related Messages