Re: r23784 - /trunk/test_suite/system_tests/relax_disp.py -- June 10, 2014 - 16:34

Hi Troels,

For the relax whitespace conventions, you should remove the spaces
around "=" for all function arguments.  See the 4th point at
http://www.nmr-relax.com/manual/Whitespace.html.  This is also the
standard Python convention and the 2to3 Python version conversion
program will make this change too.

Cheers,

Edward



On 10 June 2014 11:49,  <tlinnet@xxxxxxxxxxxxx> wrote:
> Author: tlinnet
> Date: Tue Jun 10 11:49:00 2014
> New Revision: 23784
>
> URL: http://svn.gna.org/viewcvs/relax?rev=23784&view=rev
> Log:
> Lowered chi2 value test in system test 
> Relax_disp.test_bug_22146_unpacking_r2a_r2b_cluster_NS_STAR.
>
> This is due to the data produced on 32 bit machine, and tested on 64 bit 
> machines.
> The error was:
> AssertionError: 2.4659455670347743e-05 != 0.0 within 7 places
>
> The reason for this is due to truncation artifacts.
>
> Modified:
>     trunk/test_suite/system_tests/relax_disp.py
>
> Modified: trunk/test_suite/system_tests/relax_disp.py
> URL: 
> http://svn.gna.org/viewcvs/relax/trunk/test_suite/system_tests/relax_disp.py?rev=23784&r1=23783&r2=23784&view=diff
> ==============================================================================
> --- trunk/test_suite/system_tests/relax_disp.py (original)
> +++ trunk/test_suite/system_tests/relax_disp.py Tue Jun 10 11:49:00 2014
> @@ -78,7 +78,7 @@
>          self.tmpdir = ds.tmpdir
>
>
> -    def setup_bug_22146_unpacking_r2a_r2b_cluster(self, folder=None, 
> model_analyse=None):
> +    def setup_bug_22146_unpacking_r2a_r2b_cluster(self, folder=None, 
> model_analyse=None, places = 7):
>          """Setup data for the catch of U{bug 
> #22146<https://gna.org/bugs/?22146>}, the failure of unpacking R2A and R2B, 
> when performing a clustered full dispersion models.
>
>          @keyword folder:            The name of the folder for the test 
> data.
> @@ -231,7 +231,7 @@
>
>              # Test chi2.
>              # At this point the chi-squared value at the solution should 
> be zero, as the relaxation data was created with the same parameter values.
> -            self.assertAlmostEqual(cur_spin.chi2, 0.0)
> +            self.assertAlmostEqual(cur_spin.chi2, 0.0, places = places)
>
>
>      def setup_hansen_cpmg_data(self, model=None):
> @@ -1014,7 +1014,7 @@
>          """Catch U{bug #22146<https://gna.org/bugs/?22146>}, the failure 
> of unpacking R2A and R2B, when performing a clustered NS CPMG 2SITE STAR 
> full analysis."""
>
>          # Base data setup.
> -        
> self.setup_bug_22146_unpacking_r2a_r2b_cluster(folder='ns_cpmg_2site_star_full',
>  model_analyse = MODEL_NS_CPMG_2SITE_STAR_FULL)
> +        
> self.setup_bug_22146_unpacking_r2a_r2b_cluster(folder='ns_cpmg_2site_star_full',
>  model_analyse = MODEL_NS_CPMG_2SITE_STAR_FULL, places = 4)
>
>
>      def test_cpmg_synthetic_ns3d_to_cr72(self):
>
>
> _______________________________________________
> relax (http://www.nmr-relax.com)
>
> This is the relax-commits mailing list
> relax-commits@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-commits