Re: [bug #22212] Plotting of graphs in disp speed branch is broken -- June 18, 2014

Nothing needs to be done here.  The only object ever accessed from the
target function class instance is back_calc, and this will soon be
replaced with the safer get_back_calc() calls.

Regards,

Edward


On 18 June 2014 11:17, Troels Emtekær Linnet <tlinnet@xxxxxxxxxxxxx> wrote:

And

                pack_back_calc_r2eff(spin=memo.spins[spin_index],
spin_id=memo.spin_ids[spin_index], si=si, back_calc=self.back_calc,
proton_mmq_flag=proton_mmq_flag)

And should I make a:
self.get_missing() function?


2014-06-18 11:12 GMT+02:00 Troels Emtekær Linnet <tlinnet@xxxxxxxxxxxxx>:


Hi Ed.

I worry about this, in specific_analyses/relax_disp/data.py
specific_analyses/relax_disp/optimisation.py
should
back_calc=model.back_calc
be
back_calc=model.get_back_calc()

        # Create the result command object to send back to the master.
        processor.return_object(Disp_result_command(processor=processor,
memo_id=self.memo_id, param_vector=param_vector, chi2=chi2,
iter_count=iter_count, f_count=f_count, g_count=g_count, h_count=h_count,
warning=warning, missing=self.missing, back_calc=model.back_calc,
completed=False))



2014-06-17 23:23 GMT+02:00 Edward d'Auvergne <edward@xxxxxxxxxxxxx>:

Hi,

It's not really necessary to create a bug report for the development
branches, as the bug tracker is more for communicating with users and
the users will not use the branch code.  We can just discuss on the
list.  For this, I would strongly suggest you consider adding
get_back_calc() method to the dispersion target function class:

http://thread.gmane.org/gmane.science.nmr.relax.scm/21692/focus=6238
http://thread.gmane.org/gmane.science.nmr.relax.devel/6264/focus=6265

I believe this problem will keep biting you until you solve it ;)
This is used in a few places in the dispersion modules:

$ grep back_calc specific_analyses/relax_disp/*

It would save you future pain to make sure this new numpy array
structure is either converted back to a list of lists with no blank
dispersion points by get_back_calc(), or the new structure is handled
correctly everywhere by carefully checking all code accessing it.

Regards,

Edward



On 17 June 2014 21:46, Troels E. Linnet
<NO-REPLY.INVALID-ADDRESS@xxxxxxx> wrote:

URL:
  <http://gna.org/bugs/?22212>

                 Summary: Plotting of graphs in disp speed branch is
broken
                 Project: relax
            Submitted by: tlinnet
            Submitted on: Tue 17 Jun 2014 07:46:04 PM UTC
                Category: None
Specific analysis category: None
                Priority: 5 - Normal
                Severity: 3 - Normal
                  Status: None
             Assigned to: tlinnet
         Originator Name:
        Originator Email:
             Open/Closed: Open
                 Release: Branches
         Discussion Lock: Any
        Operating System: None

    _______________________________________________________

Details:

Something is wrong with the plotting of data



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 17 Jun 2014 07:46:04 PM UTC  Name: disp_1_N.png  Size: 9kB
By:
tlinnet

<http://gna.org/bugs/download.php?file_id=21070>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?22212>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
relax-devel@xxxxxxx

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel

Re: [bug #22212] Plotting of graphs in disp speed branch is broken

Header

Content

Related Messages