Hi Troels,
Just quickly looking over the target_functions.relax_disp module, I
can see that a few models can be further simplified. All the once off
parameter conversions can be now shifted into the lib.dispersion
modules, and hence the number of arguments for these massively
decreased, see:
$ grep -A5 "# Once off parameter conversions." target_functions/relax_disp.py
These are only in the target_functions.relax_disp func_*() methods as
my attempt at speeding up the dispersion models, but you have made
this now redundant :)
One other point is that there are a lot of comments starting with "##"
which would be better as "#". I'll keep looking.
Cheers,
Edward
On 17 June 2014 22:55, Edward d'Auvergne <edward@xxxxxxxxxxxxx> wrote:
Not quite yet ;) I have to merge this back to trunk. But first I need to
see if there is anything to clean up (whitespace, comments, formatting,
naming consistency, API consistency, etc.). And then this needs to be
released to all relax users, either as relax 3.2.3, or as 3.2.4 with 3.2.3
being reserved for all other trunk changes.
For presenting this, I was thinking of a timing table from you profiling
scripts. Do you intend on creating a few more? Maybe for a numeric model
were I think there are speed ups, though no where near what you are seeing
for the analytic models. I was thinking of witing one master script that
runs all your profiling scripts, one after the other, then repeating this 10
times. The log would be captured by the script, and then there will be
timing statistics for each (grepping just for the func_*() target functions
for a single number to use), so that an average and standard deviation can
be presented for relax 3.2.2 vs. the new code. Then in the release message,
it would look like:
Speed comparison for relax-3.2.2 vs. relax-3.2.3:
Single spin analysis:
CR72: 3.2+/-0.3 s vs. 2.8+/-0.2 s -> 1.14x faster
LM63: ...
Cluster of 100 spins:
CR72: 53.5+/-2.4 s vs. 3.6+/-0.2 s -> 14.9x faster
This would be a great way to strongly present these insane speed ups. What
do you think?
Regards,
Edward
On Tuesday, 17 June 2014, Troels E. Linnet
<NO-REPLY.INVALID-ADDRESS@xxxxxxx> wrote:
Update of task #7807 (project relax):
Percent Complete: 0% => 100%
Open/Closed: Open => Closed
Effort: 0.00 => 100
_______________________________________________________
Follow-up Comment #263:
This now complete.
_______________________________________________________
Reply to this item at:
<http://gna.org/task/?7807>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
Re: [task #7807] Speed-up of dispersion models for Clustered analysis