Hi,
Sorry for the slow process, but to get you up to speed with how this
repository system and open source works will require a little time.
It will pay off in the end though as you will be able to quickly
contribute changes in the correct way. Note that to be a developer,
you will also need to subscribe to the relax-commits mailing list.
This will allow you to watch the changes I make to your code
(including applying your patches and changes). Please see below for
more details:
2009/12/14 Michael Bieri <michael.bieri@xxxxxx>:
Hi Edward
The res/filedialog.py and res/message.py are new codes, that replaces
functions of easygui.py. The res/select_model_calc.py code is also new.
it is a dialog, where users can choose the model-free model.
I've now added these files:
https://mail.gna.org/public/relax-commits/2009-12/msg00060.html
https://mail.gna.org/public/relax-commits/2009-12/msg00061.html
Note there are a number of issues:
1. No function docstrings. Please see all other parts of relax to
see how this is done.
2. Tab characters - these must be replaced by 4 spaces. All
indentation blocks must be set to 4 spaces. Which editor do you use?
This should be able to be automatically set so if you hit the tab key,
you get 4 spaces.
3. Some of the comments are repeated in res/filedialog.py and seem to be old.
4. Numerous formatting problems are identified by typing in the base
relax directory:
$ ./scripts/code_validator gui_bieri/res/filedialog.py
$ ./scripts/code_validator gui_bieri/res/message.py
$ ./scripts/code_validator gui_bieri/res/select_model_calc.py
These really need to pass the code validator! Note that sticking to
the coding convention is extremely important in a software project.
The formatting fixes could be applied as one patch for each file.
5. The commenting in res/select_model_calc.py is very low. Comments
such as "# The buttons of the selection dialog.", "# Build the main
dialog window", "# Generate the GUI layout", "# Layout the xxx
elements.", etc. whereby each GUI element and each action is explained
would be necessary for non-coders to understand.
The automatic code in relax_gui.py is newly included, so you will not be
able to find it in older versions.
Which part is the automatic code? Can this be broken up into parts
and submitted as individual patches with commit message? Cheers.
The res/settings.py code is also new and replaces the old settings.py
script. It is more graphical compared to the old one.
Did you delete the old file? If so, what I can do here is type:
$ svn rm gui_bieri/res/settings.py
$ svn ci (with commit message)
copy the new file, and then type:
$ svn add gui_bieri/res/settings.py
$ svn ci (with commit message)
If you just replaced most of the contents of the old file, then this
can be applied as a single patch.
Cheers,
Edward
Re: [task #6847] The Bieri graphical user interface.