Hi, I have a few suggestions below, but you may have already fixed these. On 27 July 2010 03:34, <michael.bieri@xxxxxxxxxxxxx> wrote:
Author: michaelbieri Date: Tue Jul 27 03:34:50 2010 New Revision: 11344 URL: http://svn.gna.org/viewcvs/relax?rev=11344&view=rev Log: Parameter to specify if grace plots are opened automatically is introduced. Modified: branches/bieri_gui/auto_analyses/relax_fit.py Modified: branches/bieri_gui/auto_analyses/relax_fit.py URL: http://svn.gna.org/viewcvs/relax/branches/bieri_gui/auto_analyses/relax_fit.py?rev=11344&r1=11343&r2=11344&view=diff ============================================================================== --- branches/bieri_gui/auto_analyses/relax_fit.py (original) +++ branches/bieri_gui/auto_analyses/relax_fit.py Tue Jul 27 03:34:50 2010 @@ -29,7 +29,7 @@ class Relax_fit: - def __init__(self, pipe_name='rx', seq_args=None, file_names=None, relax_times=None, int_method='height', mc_num=500): + def __init__(self, pipe_name='rx', seq_args=None, file_names=None, relax_times=None, , view_plots=True, int_method='height', mc_num=500):
There are two commas here preventing the code from running. Also, boolean arguments should be last of all args. The order should be: 1) Arguments, 2) Keyword arguments, 3) Boolean keyword arguments.
"""Perform relaxation curve fitting. @keyword pipe_name: The name of the data pipe to create. @@ -40,6 +40,8 @@ @type file_names: list of str @keyword relax_times: The list of relaxation times corresponding to file_names. These two lists must be of the same size. @type relax_times: list of float + @keyword view_plots: Flag to automatically viu grace plots after calculation.
There is a basic spelling mistake here. The rest is good. Cheers, Edward