Hi,
I've applied the 0001 and 0002 patches. I will also now apply the
0003 patch, but note that there is a potential issue here. The
problem resolves itself because of code lower down, but it might
appear in the future if the code changes. It is the new lines:
+ # Create the whole data_all list, where entries will be replaced later.
+ data_all = [data]*len(file_data)
+
The problem is that each element of data_all is the same thing - they
are all pointers to the same structure. So if you set data_all[9][0]
= 'x', then data_all[0][0] will also change to 'x' (as well as all
data_all[i][0]). If you combine the two lines:
+ # Create an empty data list.
+ # Format: H_name, X_name, spin_id, intensity, line.
+ data = [None, None, None, intensity_list, None]
+
+ # Create the whole data_all list, where entries will be replaced later.
+ data_all = [data]*len(file_data)
+
into one, then it should be fine. Another option is to use the
copy.deepcopy Python module function to make sure that data is
different for each element, though it's not as nice a solution. Just
wait until after I update the subversion repository with all your
patches.
Cheers,
Edward
On 2 August 2013 13:37, Troels E. Linnet
<NO-REPLY.INVALID-ADDRESS@xxxxxxx> wrote:
Follow-up Comment #46, sr #3043 (project relax):
Made changes according to suggestions.
(file #18617)
_______________________________________________________
Additional Item Attachment:
File name: seriestab2.patch.tar.gz Size:3 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/support/?3043>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
relax (http://www.nmr-relax.com)
This is the relax-devel mailing list
relax-devel@xxxxxxx
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
Re: [sr #3043] Support for NMRPipe seriesTab format *.ser