On Wed, 2006-09-13 at 21:42 +1000, Edward d'Auvergne wrote:
Chris, I've added the comments to the RelaxWarnings as well as to a few additional RelaxError classes. The RelaxWarning comments were discussed in the parent post (https://mail.gna.org/public/relax-devel/2006-08/msg00082.html, Message-id: <7f080ed10608292250u3bc0a0b0ud7a319e05ee70f28@xxxxxxxxxxxxxx>) and your post at https://mail.gna.org/public/relax-devel/2006-08/msg00083.html (Message-id: <1156930961.28764.881.camel@fbsdpcu021>). I've also made a few other cosmetic changes. The full details are given in the message sent to the relax-commits mailing list located at https://mail.gna.org/public/relax-commits/2006-09/msg00018.html (Message-id: <E1GNSEC-0004bj-DY@xxxxxxxxxxxxxxxxxx>). Btw, all the links to the relax related web pages are to help with the indexing by Google and other search engines. It appears to be working nicely. The message-ids have been added to enable the post to be precisely identified in archived email messages. The code in the 'warning' branch is very close to being in a state to merge. But before that happens I have a question about the format function. In the current code the function is duplicated, once defined as a method of the 'error.py' module, the other as a function of the RelaxWarning system class 'RelaxWarnings'. From my reading of the code, I can only see a need for the function within the RelaxWarnings class. This is the function which is called by the line 'warnings.formatwarning = self.format'. Is there a reason for the second copy?
Sorry, the additional copy of the function is a vestige of some experimentation I was doing. It should never have made it into the repository. You are right - it is only required as a method of the RelaxWarnings class. Chris