Re: r7028 - /1.3/test_suite/system_tests/palmer.py -- July 30, 2008 - 21:27

Hi Ed,

I used Windows XP Pro on my vmware virtual machine to test this issue
concerning the palmer system test. The directory separators are fine but
I nevertheless moved the creation of the temporary directory from the
script to the setUp() function so Windows does not worry when trying to
delete an absent directory. This is documented in r7030
(http://svn.gna.org/viewcvs/relax?rev=7030&view=rev).

Regards,


Séb






Edward d'Auvergne wrote:
> Seb,
>
> This is probably fine, but it might be worth trying this system test
> out on a Mac or Windows.  I'm not sure if the directory separators
> passed to the rmtree function are platform independent (I'd guess that
> this will work though).  If not, there is the value of 'os.sep' that
> can be used.  If you don't have access to these platforms for testing,
> I can give it a work out in my Windows VirtualBox image once the test
> if fully functional.
>
> Regards,
>
> Edward
>
>
> On Tue, Jul 29, 2008 at 11:40 PM,  <sebastien.morin.1@xxxxxxxxx> wrote:
>   
> > Author: semor
> > Date: Tue Jul 29 23:40:09 2008
> > New Revision: 7028
> >
> > URL: http://svn.gna.org/viewcvs/relax?rev=7028&view=rev
> > Log:
> > Improved the tearDown() function so the temporary directory is deleted 
> > after the test.
> >
> > This follows r7026 (http://svn.gna.org/viewcvs/relax?rev=7026&view=rev) 
> > and the proposal of Edward
> > d'Auvergne at: 
> > https://mail.gna.org/public/relax-devel/2008-07/msg00038.html (message ID:
> > 7f080ed10807290219m18601df6nf2df7e91848a9680@xxxxxxxxxxxxxx).
> >
> >
> > Modified:
> >    1.3/test_suite/system_tests/palmer.py
> >
> > Modified: 1.3/test_suite/system_tests/palmer.py
> > URL: 
> > http://svn.gna.org/viewcvs/relax/1.3/test_suite/system_tests/palmer.py?rev=7028&r1=7027&r2=7028&view=diff
> > ==============================================================================
> > --- 1.3/test_suite/system_tests/palmer.py (original)
> > +++ 1.3/test_suite/system_tests/palmer.py Tue Jul 29 23:40:09 2008
> > @@ -22,6 +22,7 @@
> >
> >  # Python module imports.
> >  import sys
> > +from shutil import rmtree
> >  from unittest import TestCase
> >
> >  # relax module imports.
> > @@ -47,6 +48,9 @@
> >
> >         ds.__reset__()
> >
> > +        # Remove the temporary directory created during the execution of 
> > the test_palmer() function.
> > +        rmtree(sys.path[-1] + 
> > '/test_suite/system_tests/data/temp_palmer/')
> > +
> >
> >     def test_palmer(self):
> >         """Test a complete model-free analysis using the program 
> > 'Modelfree4'."""
> >
> >
> > _______________________________________________
> > relax (http://nmr-relax.com)
> >
> > This is the relax-commits mailing list
> > relax-commits@xxxxxxx
> >
> > To unsubscribe from this list, get a password
> > reminder, or change your subscription options,
> > visit the list information page at
> > https://mail.gna.org/listinfo/relax-commits
> >
> >     
>
> _______________________________________________
> relax (http://nmr-relax.com)
>
> This is the relax-devel mailing list
> relax-devel@xxxxxxx
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel
>
>